fix: renaming standaloneDeployment variable to be consistent

Signed-off-by: Nuno Martins <nunojdcm@gmail.com>
flyteorg · Apr 5, 2024 · 1bf1bc4 · 1bf1bc4
1 parent 452538a
commit 1bf1bc4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/charts/flyte-core/templates/admin/deployment.yaml b/charts/flyte-core/templates/admin/deployment.yaml
@@ -74,7 +74,7 @@ spec:
             {{- end }}
             {{- end }}
         {{- end }}
-        {{- if and (.Values.cluster_resource_manager.enabled) (not .Values.cluster_resource_manager.standalone_deploy) }}
+        {{- if and (.Values.cluster_resource_manager.enabled) (not .Values.cluster_resource_manager.standaloneDeployment) }}
         - command:
           - flyteadmin
           - --config

diff --git a/charts/flyte-core/templates/clusterresourcesync/deployment.yaml b/charts/flyte-core/templates/clusterresourcesync/deployment.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.cluster_resource_manager.enabled }}
+{{- if and (.Values.cluster_resource_manager.enabled) (.Values.cluster_resource_manager.standaloneDeployment) }}
 apiVersion: apps/v1
 kind: Deployment
 metadata:

diff --git a/charts/flyte-core/values-eks.yaml b/charts/flyte-core/values-eks.yaml
@@ -350,7 +350,7 @@ cluster_resource_manager:
   # -- Enables the Cluster resource manager component
   enabled: true
   # -- Starts the cluster resource manager in standalone mode with requisite auth credentials to call flyteadmin service endpoints
-  standalone_deploy: false
+  standaloneDeployment: false
   config:
     cluster_resources:
       customData:

diff --git a/charts/flyte-core/values-gcp.yaml b/charts/flyte-core/values-gcp.yaml
@@ -331,7 +331,7 @@ cluster_resource_manager:
   # -- Enables the Cluster resource manager component
   enabled: true
   # -- Starts the cluster resource manager in standalone mode with requisite auth credentials to call flyteadmin service endpoints
-  standalone_deploy: false
+  standaloneDeployment: false
   config:
     cluster_resources:
       customData:

diff --git a/docs/deployment/plugins/k8s/index.rst b/docs/deployment/plugins/k8s/index.rst
@@ -623,7 +623,7 @@ Specify plugin configuration
                           spark: spark
                 cluster_resource_manager:
                   enabled: true 
-                  standalone_deploy: false
+                  standaloneDeployment: false
                   # -- Resource templates that should be applied
                   templates:
                     # -- Template for namespaces resources
@@ -735,7 +735,7 @@ Specify plugin configuration
                             spark: spark 
                     cluster_resource_manager:
                       enabled: true
-                      standalone_deploy: false
+                      standaloneDeployment: false
                       config:
                         cluster_resources:
                           customData: