Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Enhancements #30

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Graph Enhancements #30

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Labels
spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface

Comments

@georgesnelling
Copy link
Contributor

This is to cover any overflow / nice-to-haves on the graph implementation after the initial usable version. Some ideas:

  • Diving into layers of the graph (i.e. expanding subworkflow nodes inline)
  • Zooming/panning
  • Hover animations, including highlighting data flow in adjacent nodes
  • Animations on nodes in progress
  • Different rendering for nodes which were not executed
@schottra schottra added the ui Admin console user interface label Dec 11, 2019
@schottra schottra added spec-first This issue needs a spec to be created and then work. It should be an independent stream and removed pri2 labels Jul 6, 2020
@schottra schottra removed their assignment Jul 6, 2020
@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Bug bankruptcy.

@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
@slai
Fix invalid filter function error message (#30)
f7b97ec 
* Fix invalid filter function error message

Currently, if you use an invalid filter function, e.g. `neq(phase,RUNNING)`, the error message (via the GRPC gateway) is -

```
{"error":"unsupported filter expression: contains","code":3,"message":"unsupported filter expression: contains"}
```

This is confusing as it names a function that isn't actually the one that's invalid. This happens because the message takes a FilterExpression value, but when the function is invalid, the filter expression value is its zero-value, `0`, which happens to correspond to the value for `Contains`.

This PR fixes this by clarifying the message and passes the function string directly.

* use function term instead of operator

* remove unused variable
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
@EngHabu
Implement a recursive finalize in node executor (#30)
8291add 
Implement Finalize in Dynamic Node Handler.
The change is more nuanced than this. It changes how Dynamic Nodes fail.

- When a sub-node in a dynamic node fails, the dynamic node will continue to be marked as `Running` in this cycle but change its internal phase to `failing`
- Next cycle, the dynamic node will abort all other sub-nodes that are still running then mark itself as `retryable failure`
eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
@katrogan
Undeprecate principal (#30)
8778b76
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@bnsblue
Fix exception handling of caching errors for copyImpl (#30)
322ef24 
* fix exception handling of caching errors for copyImpl

* add test for the fix in copyImpl
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@EngHabu
Refactor plugin api (#30)
c7dd2eb 
Original PR: flyteorg/flyteplugins#1

Goal:
Plugins should be able to manage complex state and have a simplified interface to perform

* resource state management
* add finalizers to every task
* add custom abort handlers
* K8s and services should have a simpler interface to write plugins, but the power of raw plugins is available to the plugin writer.
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@honnix
Support gRPC health checking (#30)
8a13d53
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
@yindia
Added script for checking diff of generated code (#30)
cd60809 
* Added ci check for go generate

Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario referenced this issue in eapolinario/flyte Aug 9, 2023
@EngHabu
Implement a recursive finalize in node executor (#30)
42c7f33 
Implement Finalize in Dynamic Node Handler.
The change is more nuanced than this. It changes how Dynamic Nodes fail.

- When a sub-node in a dynamic node fails, the dynamic node will continue to be marked as `Running` in this cycle but change its internal phase to `failing`
- Next cycle, the dynamic node will abort all other sub-nodes that are still running then mark itself as `retryable failure`
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@bnsblue
Fix exception handling of caching errors for copyImpl (#30)
faa4fd3 
* fix exception handling of caching errors for copyImpl

* add test for the fix in copyImpl
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@slai
Fix invalid filter function error message (#30)
f4de56e 
* Fix invalid filter function error message

Currently, if you use an invalid filter function, e.g. `neq(phase,RUNNING)`, the error message (via the GRPC gateway) is -

```
{"error":"unsupported filter expression: contains","code":3,"message":"unsupported filter expression: contains"}
```

This is confusing as it names a function that isn't actually the one that's invalid. This happens because the message takes a FilterExpression value, but when the function is invalid, the filter expression value is its zero-value, `0`, which happens to correspond to the value for `Contains`.

This PR fixes this by clarifying the message and passes the function string directly.

* use function term instead of operator

* remove unused variable
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@EngHabu
Refactor plugin api (#30)
00bd32d 
Original PR: flyteorg/flyteplugins#1

Goal:
Plugins should be able to manage complex state and have a simplified interface to perform

* resource state management
* add finalizers to every task
* add custom abort handlers
* K8s and services should have a simpler interface to write plugins, but the power of raw plugins is available to the plugin writer.
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@honnix
Support gRPC health checking (#30)
4204253
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@yindia
Added script for checking diff of generated code (#30)
9b828df 
* Added ci check for go generate

Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
@yindia
Added precommit (#30)
67d8e64 
* Added boilerplate automation
Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
@katrogan
Undeprecate principal (#30)
a05a418
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@wild-endeavor
Use flytectl (#30)
d1e215c
eapolinario pushed a commit that referenced this issue Sep 13, 2023
@katrogan @eapolinario
Undeprecate principal (#30)
a0c0d32 
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario referenced this issue in eapolinario/flyte Sep 26, 2023
@honnix
Support gRPC health checking (#30)
14884de
eapolinario referenced this issue in eapolinario/flyte Apr 30, 2024
@kumare3
Index is too verbose for the docs, fix it (#30)
a5f000a
eapolinario referenced this issue in eapolinario/flyte Apr 30, 2024
@kumare3
Index is too verbose for the docs, fix it (#30)
4367c0b
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@kumare3 @austin362667
Index is too verbose for the docs, fix it (flyteorg#30)
b45c130
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@kumare3 @robert-ulbrich-mercedes-benz
Index is too verbose for the docs, fix it (flyteorg#30)
41514ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EngHabu @georgesnelling @schottra