Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework dynamic node relationships in data model #33

Closed
georgesnelling opened this issue Nov 19, 2019 · 1 comment
Closed

Rework dynamic node relationships in data model #33

georgesnelling opened this issue Nov 19, 2019 · 1 comment
Assignees
@EngHabu
Labels
pri2

Comments

@georgesnelling
Copy link
Contributor

Admin currently allows tasks to be parents of other nodes (1->many) and nodes to be parents of other tasks (1-1). This has lead to some confusion/assumptions:

  • While tasks do yield nodes, they, tasks, finish executing well before those nodes start. It's not entirely accurate to have this task->node parent relationship
  • Due to how they are currently presented in the data model, the nested UX looks confusing with the task row showing success and sub-rows showing running (indicating the yielded nodes are still running).

We have talked separately on different occasions about how this should ideally be represented. This task is to track the concrete steps towards a better model.
@EngHabu
Copy link
Contributor

EngHabu commented Jan 29, 2021

Done

@EngHabu EngHabu closed this as completed Jan 29, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@wild-endeavor
Metadata url and base url as items in the auth context (flyteorg#33)
5cd1bfd 
Was incorrectly using `path.Join` in order to join URL paths.  This would've failed on windows, and also the redirect for the metadata and user info endpoints ended up being like `http:/blah.okta.com/...` instead of having the correct `//`.

Added a couple functions to the context interface to get these.
Added more todo's around config object to implement the actual use of the discovery endpoints. This will get rid of a lot of the URLs in the config.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@migueltol22
Merge pull request flyteorg#33 from lyft/mtoledo/update-flyteplugins-…
241f81e 
…version

bump flyteplugins version
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@bnsblue
add source and destination in CopyRaw's error msg (flyteorg#33)
7292f20
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@EngHabu
Fix array log link phase to show interpreted phase instead (flyteorg#33)
3a30f6d 
* Use the correct phase in the log link

* Actually fix the env var override issue

* make unit tests deterministic

* PR Comments
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@kumare3
Migrate Lyft -> Flyteorg (flyteorg#33)
1bfd5b8 
* Migrate Lyft -> Flyteorg

 - Also removes uneeded dependencies
 - Cleans up makefile

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* All linter errors and logical errors fixed

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@flyte-bot
Update Boilerplate (flyteorg#33)
389cb8d 
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@migueltol22
Merge pull request flyteorg#33 from lyft/mtoledo/update-flyteplugins-…
61957e8 
…version

bump flyteplugins version
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@bnsblue
add source and destination in CopyRaw's error msg (flyteorg#33)
80f8ea7
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@wild-endeavor
Metadata url and base url as items in the auth context (flyteorg#33)
30d340c 
Was incorrectly using `path.Join` in order to join URL paths.  This would've failed on windows, and also the redirect for the metadata and user info endpoints ended up being like `http:/blah.okta.com/...` instead of having the correct `//`.

Added a couple functions to the context interface to get these.
Added more todo's around config object to implement the actual use of the discovery endpoints. This will get rid of a lot of the URLs in the config.
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Fix array log link phase to show interpreted phase instead (flyteorg#33)
fbc2ee3 
* Use the correct phase in the log link

* Actually fix the env var override issue

* make unit tests deterministic

* PR Comments
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@kumare3
Migrate Lyft -> Flyteorg (flyteorg#33)
d050dcf 
* Migrate Lyft -> Flyteorg

 - Also removes uneeded dependencies
 - Cleans up makefile

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* All linter errors and logical errors fixed

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@flyte-bot
Update Boilerplate (flyteorg#33)
af4604d 
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@EngHabu
Update PR Template to automatically close issues when merged (flyteor…
c239209 
…g#33)

* Update PR Template to automatically close issues when merged

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>

* Add instructions to know when to remove 'fixes' keyword

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
eapolinario pushed a commit that referenced this issue Sep 12, 2023
@wild-endeavor
flytekit to v0.19.0 (#33)
d4c3805 
Signed-off-by: wild-endeavor <wild-endeavor@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Sep 26, 2023
@kumare3
Migrate Lyft -> Flyteorg (flyteorg#33)
aaa611a 
* Migrate Lyft -> Flyteorg

 - Also removes uneeded dependencies
 - Cleans up makefile

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* All linter errors and logical errors fixed

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngHabu EngHabu

Labels
pri2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EngHabu @georgesnelling