Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Parsing issue using multiple same filters in Admin rest endpoint #515

Closed
1 of 20 tasks
wild-endeavor opened this issue Sep 18, 2020 · 3 comments
Closed
1 of 20 tasks
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@wild-endeavor
Copy link
Contributor

Describe the bug
This doesn't work in Chrome:

https://flyte.lyft.net/api/v1/launch_plans/teamname/development?limit=100&filters=eq(workflow.version,f01f1b14f347025573fddfe2769499b29e0eb2af)%20eq(workflow.name,TeamNameTrainingSubWorkflow)

it returns an error

{
  "error": "unrecognized filter function: eq(workflow.version,f01f1b14f347025573fddfe2769499b29e0eb2af) eq",
  "code": 3,
  "message": "unrecognized filter function: eq(workflow.version,f01f1b14f347025573fddfe2769499b29e0eb2af) eq"
}

Expected behavior
Filtered response

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:
Go to URL.

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 18, 2020
@wild-endeavor
Copy link
Contributor Author

Using %2b% works however. Maybe there's nothing to do here?

@katrogan
Copy link
Contributor

Seems like a browser standard:

  • means a space only in application/x-www-form-urlencoded content, such as the query part of a URL

@EngHabu
Copy link
Contributor

EngHabu commented Aug 30, 2021

Closing per above comments

@EngHabu EngHabu closed this as completed Aug 30, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Add line how to add nodejs plugin to asdf, to simplify setup
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
* Add tensorflow to loader.go

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* lint

Signed-off-by: Kevin Su <pingsutw@gmail.com>

Signed-off-by: Kevin Su <pingsutw@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
* Add tensorflow to loader.go

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* lint

Signed-off-by: Kevin Su <pingsutw@gmail.com>

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

3 participants