Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flyteadmin - FlyteAdmin will always add base_exec_id unless it is already added #4140

Closed
wants to merge 3 commits into from

Conversation

eapolinario
Copy link
Contributor

TL;DR

Automatically adds base_exec_id label with the value of current execution or a previous base_exec_id if it exists.

Reasons:

  1. Make it possible to retrieve all executions launched by the same base execution id (even recursively)
  2. users could group executions using their own base exec id
  3. flytectl get executions or remote list executions can use this label as a filter to retrieve high level progress of all subworkflows

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

kumare3 and others added 3 commits September 21, 2023 21:27
Reasons:
1. Make it possible to retrieve all executions launched by the same base execution id (even recursively)
2. users could group executions using their own base exec id
3. flytectl get executions or remote list executions can use this label as a filter to retrieve high level progress of all subworkflows

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d9586b0) 58.98% compared to head (eccc151) 59.32%.

❗ Current head eccc151 differs from pull request most recent head 24c7676. Consider uploading reports for the commit 24c7676 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
+ Coverage   58.98%   59.32%   +0.33%     
==========================================
  Files         619      550      -69     
  Lines       52804    39701   -13103     
==========================================
- Hits        31146    23551    -7595     
+ Misses      19174    13829    -5345     
+ Partials     2484     2321     -163     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/pkg/manager/impl/execution_manager.go 73.07% <75.00%> (+2.54%) ⬆️

... and 555 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants