-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flytepropeller] Add Tests in v1alpha.go including array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
with 0.13% Coverage Improvment
#4234
Conversation
Signed-off-by: Future Outlier <eric901201@gmai.com>
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4234 +/- ##
==========================================
+ Coverage 59.59% 60.23% +0.64%
==========================================
Files 632 562 -70
Lines 53628 40297 -13331
==========================================
- Hits 31960 24274 -7686
+ Misses 19147 13669 -5478
+ Partials 2521 2354 -167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
array_test.go
, branch_test.go
, error_test.go
, and iface_test.go
with 0.13% Coverage Improvment
… flytepropeller-pkg-apis-flyteworkflow-test Signed-off-by: Future Outlier <eric901201@gmai.com>
… flytepropeller-pkg-apis-flyteworkflow-test
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
@pingsutw I think it is able to be approved and merged, please take a look, thanks a lot |
TL;DR
Please take a look at the line I change the package from
v1alpha1_test
tov1alpha1
.I really think it is unnecessary to use a new package, thanks a lot!
https://github.com/flyteorg/flyte/pull/4234/files#diff-e0b8581c1dadc5bdd862a6388d98c81d652943ef1f46c7eeb18d14f6665b7fabR1
Tracking issue
Fixes #4209
Describe your changes
Screenshots
before
after