Not revisiting task nodes and correctly incrementing parallelism

[hamersaw]

Tracking issue

NA

Describe your changes

Currently, if the plugin state has already been observed we immediately return without incrementing parallelism or marking the task as "dirty", indicating that it has already been processed this round. This means that, in scenarios where a task is the downstream dependency of multiple nodes, tasks may be unnecessarily evaluated multiple times within a single round. More seriously, if the task state has no changed (ex. in same phase as previous round) then additional tasks will be scheduled to satisfy the parallelism. This means that, effectively max_parallelism settings may be ignored.

In this PR we correctly increment parallelism if the state has already been seen and mark the task node as "dirty" to indicate that it should not be evaluated again this round.

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Screenshots

NA

Note to reviewers

NA

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1074826) 59.04% compared to head (e278412) 59.32%.
Report is 10 commits behind head on master.

❗ Current head e278412 differs from pull request most recent head fafd673. Consider uploading reports for the commit fafd673 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4318      +/-   ##
==========================================
+ Coverage   59.04%   59.32%   +0.28%     
==========================================
  Files         614      544      -70     
  Lines       52006    38936   -13070     
==========================================
- Hits        30705    23099    -7606     
+ Misses      18850    13556    -5294     
+ Partials     2451     2281     -170     

Flag	Coverage Δ
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...lytepropeller/pkg/controller/nodes/task/handler.go	60.39% <33.33%> (+1.74%)	⬆️

... and 551 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.