completing retries even if minSuccesses are achieved #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4338 +/- ##
==========================================
+ Coverage 59.07% 59.35% +0.27%
==========================================
Files 614 544 -70
Lines 52006 38975 -13031
==========================================
- Hits 30723 23133 -7590
+ Misses 18832 13562 -5270
+ Partials 2451 2280 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Nov 2, 2023
Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
reviewed
Nov 6, 2023
| @@ -273,7 +273,8 @@ func SummaryToPhase(ctx context.Context, minSuccesses int64, summary arraystatus | |||
| logger.Infof(ctx, "Array is still running and waiting for resources totalWaitingForResources[%v]", totalWaitingForResources) | |||
| return PhaseWaitingForResources | |||
| } | |||
| if totalSuccesses >= minSuccesses && totalRunning == 0 { | |||
| //if totalSuccesses >= minSuccesses && totalRunning == 0 && totalRetryableFailures == 0 { | |||
Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes #4331
Describe your changes
Check if any subtasks are in phase retryable failure before transitioning to succeeded.
Check all the applicable boxes
Screenshots
NA
Note to reviewers
NA