Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put ticker back in place in propeller gc #4490

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Put ticker back in place in propeller gc #4490

merged 2 commits into from
Nov 28, 2023

Conversation

eapolinario
Copy link
Contributor

Tracking issue

Issue raised in https://github.com/flyteorg/flyte/pull/4199/files#r1406729862

Describe your changes

As title says.

clock.RealClock implements the WithTicker interface (including the NewTicker). We use an instance of this type to configure the garbage collector.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2023
@hamersaw
Copy link
Contributor

Saw briefly the difference between WithTicker and using Clock.Tick. Do you understand the differences? TL;DR?

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c300fa4) 59.73% compared to head (4716df1) 59.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4490   +/-   ##
=======================================
  Coverage   59.73%   59.74%           
=======================================
  Files         636      636           
  Lines       53855    53855           
=======================================
+ Hits        32169    32174    +5     
+ Misses      19154    19149    -5     
  Partials     2532     2532           
Flag Coverage Δ
unittests 59.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor Author

Saw briefly the difference between WithTicker and using Clock.Tick. Do you understand the differences? TL;DR?

WithTicker returns a proper Ticker object whereas clock.Tick returns a channel to the ticking channel (so very indirectly you have access to the ticker).

I don't think it matters much, since we immediately use the channel provided by the ticker object in runGC.

@eapolinario eapolinario merged commit 268feae into master Nov 28, 2023
45 checks passed
@eapolinario eapolinario deleted the gc-ticker branch November 28, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants