Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $HOME resolution and webhook namespace #4509

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Nov 30, 2023

Tracking issue

Describe your changes

  • Automatically resolve $HOME references in the config file.
  • Fix the webhook configuration namespace to use POD_NAMESPACE downstream API

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0541851) 59.40% compared to head (0556293) 59.36%.

Files Patch % Lines
flytepropeller/pkg/webhook/init_cert.go 0.00% 6 Missing ⚠️
flytepropeller/pkg/webhook/config/config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4509      +/-   ##
==========================================
- Coverage   59.40%   59.36%   -0.04%     
==========================================
  Files         638      638              
  Lines       53954    53957       +3     
==========================================
- Hits        32051    32033      -18     
- Misses      19374    19394      +20     
- Partials     2529     2530       +1     
Flag Coverage Δ
unittests 59.36% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeevb
jeevb previously approved these changes Nov 30, 2023
Copy link
Contributor

@jeevb jeevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
eapolinario
eapolinario previously approved these changes Nov 30, 2023
@eapolinario eapolinario marked this pull request as ready for review November 30, 2023 23:11
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 30, 2023
pingsutw
pingsutw previously approved these changes Nov 30, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 30, 2023
@eapolinario eapolinario enabled auto-merge (squash) November 30, 2023 23:14
@EngHabu EngHabu dismissed stale reviews from pingsutw and eapolinario via 0556293 November 30, 2023 23:18
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 30, 2023
@eapolinario eapolinario merged commit 64f097f into master Nov 30, 2023
47 of 49 checks passed
@eapolinario eapolinario deleted the flyte-start-errors branch November 30, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants