-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix $HOME resolution and webhook namespace #4509
Conversation
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4509 +/- ##
==========================================
- Coverage 59.40% 59.36% -0.04%
==========================================
Files 638 638
Lines 53954 53957 +3
==========================================
- Hits 32051 32033 -18
- Misses 19374 19394 +20
- Partials 2529 2530 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Tracking issue
Describe your changes
$HOME
references in the config file.POD_NAMESPACE
downstream APICheck all the applicable boxes