Update environment_setup.md #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worflow names in the section 'Visualizing workflows' are configured incorrectly. The corrections have been made. Signed-off-by: ssen85 <shubhabrata.sen@gmail.com> Signed-off-by: ssen85 <shubhabrata.sen@gmail.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4963 +/- ##
==========================================
- Coverage 58.97% 58.94% -0.03%
==========================================
Files 645 645
Lines 55506 55506
==========================================
- Hits 32732 32720 -12
- Misses 20174 20186 +12
Partials 2600 2600
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
neverett
approved these changes
Feb 29, 2024
pingsutw
approved these changes
Mar 4, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The worflow names in the section 'Visualizing workflows' are configured incorrectly as ' basics.workflow.simple_wf'. The execution of the commands gives a 'Workflow not found error'.
What changes were proposed in this pull request?
The workflow names have been changed to 'workflow.simple_wf'.
How was this patch tested?
The command was executed after making these changes. The desired output was achieved.
flytectl get workflows
--project flytesnacks
--domain development
--version
-o doturl
workflow.simple_wf
Setup process
Screenshots
Check all the applicable boxes
Signed-off-by: ssen85 shubhabrata.sen@gmail.com