Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open ai secret name #5098

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Fix open ai secret name #5098

merged 1 commit into from
Mar 23, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Mar 22, 2024

Tracking issue

NA

Why are the changes needed?

Secret name is actually slightly different. The code expects it to be named flyte_openai_api_key.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (b6f35ad) to head (b787f3a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5098      +/-   ##
==========================================
- Coverage   58.99%   58.99%   -0.01%     
==========================================
  Files         645      645              
  Lines       55648    55648              
==========================================
- Hits        32831    32830       -1     
- Misses      20222    20223       +1     
  Partials     2595     2595              
Flag Coverage Δ
unittests 58.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) March 22, 2024 21:51
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@eapolinario eapolinario merged commit feb4777 into master Mar 23, 2024
47 of 48 checks passed
@eapolinario eapolinario deleted the eapolinario-patch-2 branch March 23, 2024 05:00
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 23, 2024
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants