Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sandbox): Add guide for running newest flyteconsole in flyte sandbox #5100

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Mar 25, 2024

Why are the changes needed?

Clarify instructions and add make target to rebuild single-binary flyte console dependency. There is currently no guide about how to run the newest flyteconsole in flyte demo sandbox.

What changes were proposed in this pull request?

Update the docs and add a new Makefile target clean.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (feb4777) to head (cd33c28).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5100      +/-   ##
==========================================
+ Coverage   58.98%   58.99%   +0.01%     
==========================================
  Files         645      645              
  Lines       55648    55648              
==========================================
+ Hits        32824    32830       +6     
+ Misses      20229    20223       -6     
  Partials     2595     2595              
Flag Coverage Δ
unittests 58.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
…dbox

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the docs/run-flyteconsole-in-sandbox branch from 2fc931f to cd33c28 Compare March 25, 2024 16:08
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PR desc?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2024
@wild-endeavor
Copy link
Contributor

oh it was there, missed it sorry. updated it a bit.

@wild-endeavor wild-endeavor changed the title docs(sandbox): Add guide for running newest fltyeconsole in flyte sandbox docs(sandbox): Add guide for running newest flyteconsole in flyte sandbox Mar 25, 2024
@wild-endeavor wild-endeavor merged commit cb6384a into flyteorg:master Mar 25, 2024
48 checks passed
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
…#5100)

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants