Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional org param to ProjectGetRequest #5118

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

katrogan
Copy link
Contributor

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@katrogan katrogan requested a review from pingsutw March 26, 2024 20:11
@dosubot dosubot bot added the enhancement New feature or request label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (998c9ce) to head (9e1b7c8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5118      +/-   ##
==========================================
+ Coverage   58.56%   59.00%   +0.44%     
==========================================
  Files         494      645     +151     
  Lines       42989    55672   +12683     
==========================================
+ Hits        25176    32850    +7674     
- Misses      15818    20226    +4408     
- Partials     1995     2596     +601     
Flag Coverage Δ
unittests 59.00% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2024
@katrogan katrogan merged commit c21ded6 into master Mar 26, 2024
47 of 48 checks passed
@katrogan katrogan deleted the add-org-get-project branch March 26, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants