Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-restful to v3.12.0 #5140

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ddl-ebrown
Copy link
Contributor

@ddl-ebrown ddl-ebrown commented Mar 29, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

  • Resolves high vuln PRISMA-2022-0227 related to authentication bypass

What changes were proposed in this pull request?

  • Upgrades v3.9.0 and v3.11.0 to use v3.12.0 consistently

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

 - Resolves high vuln PRISMA-2022-0227 related to authentication bypass

Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. security Issues related to Security improvements labels Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (8bb5b8c) to head (2a77736).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5140      +/-   ##
==========================================
+ Coverage   59.09%   59.11%   +0.01%     
==========================================
  Files         645      645              
  Lines       55540    55540              
==========================================
+ Hits        32824    32830       +6     
+ Misses      20127    20123       -4     
+ Partials     2589     2587       -2     
Flag Coverage Δ
unittests 59.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddl-ebrown ddl-ebrown changed the title Upgrade go-restful to v3.12.0 everywhere Upgrade go-restful to v3.12.0 Mar 29, 2024
@eapolinario eapolinario merged commit 921a536 into flyteorg:master Mar 29, 2024
48 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 29, 2024
@ddl-ebrown ddl-ebrown deleted the upgrade-gorestful branch March 29, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer security Issues related to Security improvements size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants