Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] [flyteagent] Add ExecuteTaskSync function timeout setting #5209

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Apr 10, 2024

Tracking issue

#3936

Why are the changes needed?

We want to let users be able to set sync task's timeout, and it should be different apart from CreateTask.

What changes were proposed in this pull request?

Create a new context before executing ExecuteTaskSync.
We can set the timeout of ExecuteTaskSync function by adding
ExecuteTaskSync: 10s in our flytepropeller config map.
for example.

agent-service:
    supportedTaskTypes:
      - chatgpt
      - sensor
    defaultAgent:
      endpoint: "localhost:8000"
      insecure: true
      timeouts:
        ExecuteTaskSync: 10s
      defaultTimeout: 10s

How was this patch tested?

remote execution and unit tests.

Setup process

single-binary-dev

Screenshots

image image image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5208

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Apr 10, 2024
@Future-Outlier
Copy link
Member Author

Future-Outlier commented Apr 10, 2024

In the future, stream task should have 1 more setting for longer stream response, right?
This is my misunderstanding, now I understood!

@Future-Outlier Future-Outlier enabled auto-merge (squash) April 10, 2024 03:14
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
@pingsutw pingsutw merged commit 674367f into master Apr 10, 2024
46 checks passed
@pingsutw pingsutw deleted the add-sync-agent-timeout-settings-by-context branch April 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants