Support postgres extra options [gcp] #27
Conversation
Right now it is enforced to use sslmode when flyte admin is connecting to postgres and password provided. The PR make it possible to connect to postgres when disabling sslmode.
| return fmt.Sprintf("host=%s port=%d dbname=%s user=%s password=%s", | ||
| p.config.Host, p.config.Port, p.config.DbName, p.config.User, p.config.Password) | ||
| return fmt.Sprintf("host=%s port=%d dbname=%s user=%s password=%s %s", | ||
| p.config.Host, p.config.Port, p.config.DbName, p.config.User, p.config.Password, p.config.ExtraOptions) |
There was a problem hiding this comment.
@katrogan will this break our production deployment? We do have options: sslmode=disable in our yaml settings I think.
Also, post IAM role integration, the password empty check is no longer a proxy for sandbox deployment.
There was a problem hiding this comment.
yeah it might be better to only format the password when it's not empty
There was a problem hiding this comment.
I'm a bit confused. How does this work today without this PR?
There was a problem hiding this comment.
If password is provided, it will discard the option and always use sslmode. But cloudsql proxy does not use sslmode
There was a problem hiding this comment.
I mean I couldn't find anywhere in the code reading ExtraOptions. I guess I'm missing something.
|
Any chance you could also update the |
This replicates flyteorg/flyteadmin#27
This replicates flyteorg/flyteadmin#27
* origin/master: Metadata url and base url as items in the auth context (#33) OAuth2 (#8) Log links merging logic should take log link names into account (#32) Generic type support in workflow compiler (#31) Fix invalid filter function error message (#30) Support postgres extra options [gcp] (#27) Fix no auth provider [gcp] (#28)
This replicates flyteorg/flyteadmin#27
This replicates flyteorg/flyteadmin#27
* Support postgres extra options [gcp] Right now it is enforced to use sslmode when flyte admin is connecting to postgres and password provided. The PR make it possible to connect to postgres when disabling sslmode. * Add test * Add test for case with pwd but no extra option
Right now it is enforced to use sslmode when flyte admin is connecting to postgres and password provided. The PR make it possible to connect to postgres when disabling sslmode.