feat: add domain settings for project dashboard #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
4nalog
commented
Feb 16, 2023
| @@ -166,7 +186,7 @@ export const ProjectDashboard: React.FC<ProjectDashboardProps> = ({ | |||
| ); | |||
| return projectDomainAtributes; | |||
| }, | |||
| staleTime: Infinity, | |||
| enabled: !!projectAttributesQuery.data, | |||
There was a problem hiding this comment.
The behaviour when the project settings error out is not clear. So we fetch projectDomainAttributes only once we have the upper level query.
4nalog
commented
Feb 16, 2023
| @@ -206,9 +230,7 @@ export const ProjectDashboard: React.FC<ProjectDashboardProps> = ({ | |||
| </Typography> | |||
| <Typography variant="h5">{t('tasksTotal', numberOfTasks)}</Typography> | |||
| </div> | |||
| <WaitForQuery query={projectDomainAttributesQuery}> | |||
There was a problem hiding this comment.
Not sure what the best way to implement this is but ideal scenario we nest the for project attributes and project domain attributes.
I implemented this at a non-component level by disabling the projectDomainAttributes query until we have the data for project attributes
ursucarina
reviewed
Feb 16, 2023
4nalog
commented
Feb 16, 2023
ursucarina
requested review from
a team,
ursucarina,
eugenejahn and
olga-union
and removed request for
a team
jsonporter
previously approved these changes
Feb 21, 2023
4nalog
force-pushed
the
soham/domain-settings-section
branch
from
d4186fb
to
338bca5
Compare
ursucarina
reviewed
Feb 22, 2023
packages/console/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@flyteorg/console", | |||
| "version": "0.0.8", | |||
| "version": "0.0.9", | |||
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
Signed-off-by: 4nalog <4nalog@protonmail.com>
4nalog
force-pushed
the
soham/domain-settings-section
branch
from
b668295
to
c2bf77a
Compare
jsonporter
approved these changes
Feb 23, 2023
|
Congrats on merging your first pull request! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds support for showing project attributes and project domain attributes in the Project Dashboard for flyteconsole.
Type
Are all requirements met?
Complete description
Currently, there is no way for users to directly tell project attributes, project domain attributes. This PR adds support for showing project attributes and project domain attributes in the Project Dashboard for flyteconsole.
Note: We currently merge the project attributes with the project domain attributes in a single view. In future and as per designs, we will indicate separately global and project level domain settings so that users can see what changed
Tracking Issue
https://github.com/flyteorg/flyteconsole/issues/382
Follow-up issue
https://github.com/flyteorg/flyteconsole/issues/382