Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date): Default show datetime in local timezone instead of UTC #855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Member

TL;DR

Show datetime in the local timezone instead of UTC in most of the UI.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Screenshot from 2024-03-26 01-12-43
Screenshot from 2024-03-26 01-14-02

Tracking Issue

Resolves: flyteorg/flyte#2908

Follow-up issue

NA

@MortalHappiness MortalHappiness force-pushed the feature/#2908-local-timezone-timestamp branch from 4811c15 to 8f8e6a4 Compare March 26, 2024 06:22
Resolves: flyteorg/flyte#2908
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/#2908-local-timezone-timestamp branch from 8f8e6a4 to 6fc6afa Compare March 27, 2024 06:06
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 55.29%. Comparing base (3920ce8) to head (6fc6afa).

Files Patch % Lines
...rc/components/Executions/ExecutionDetails/utils.ts 25.00% 3 Missing ⚠️
...Executions/Tables/WorkflowExecutionTable/cells.tsx 0.00% 2 Missing ⚠️
packages/oss-console/src/common/formatters.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   55.30%   55.29%   -0.01%     
==========================================
  Files         564      564              
  Lines       14620    14622       +2     
  Branches     2668     2669       +1     
==========================================
  Hits         8085     8085              
- Misses       6535     6537       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Set timestamps to local timezone in console
1 participant