Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

integrate Bubbletea CLI #468

Closed
wants to merge 5 commits into from
Closed

Conversation

zychen5186
Copy link
Contributor

@zychen5186 zychen5186 commented Mar 28, 2024

TL;DR

Integrate bubble tea CLI into flytectl

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Still under development, current progress:
Command list selection
image

get execution pagination
image

TODO:
Pagination for other get commands

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (848ab01) to head (468919e).
Report is 1 commits behind head on master.

❗ Current head 468919e differs from pull request most recent head b2907d6. Consider uploading reports for the commit b2907d6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files         148      148           
  Lines        6643     6645    +2     
=======================================
+ Hits         4494     4496    +2     
  Misses       1859     1859           
  Partials      290      290           
Flag Coverage Δ
unittests 67.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
@katrogan
Copy link
Contributor

hey @zychen5186 this looks awesome! any reason to not merge this?

@troychiu
Copy link
Member

For easier review, we decided to separate this into small PRs.
FYI: #473

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants