This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add span uri #415
Open
Add span uri #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Yicheng-Lu-llll
force-pushed
the
Flytekit-Metrics-Exploration
branch
from
91b56d5
to
29f4992
Compare
pingsutw
reviewed
Jun 16, 2023
| @@ -171,6 +171,8 @@ message NodeExecutionClosure { | |||
| // dynamic_job_spec_uri is the location of the DynamicJobSpec proto message for a DynamicWorkflow. This is required | |||
| // to correctly recover partially completed executions where the subworkflow has already been compiled. | |||
| string dynamic_job_spec_uri = 12; | |||
|
|
|||
| string span_uri = 13; | |||
| @@ -110,6 +110,8 @@ message NodeExecutionEvent { | |||
| // literal inputs are initially copied. The event however will not be sent until after the copy completes. | |||
| // Extracting both of these timestamps facilitates a more accurate portrayal of the evaluation time-series. | |||
| google.protobuf.Timestamp reported_at = 21; | |||
|
|
|||
| string span_uri = 22; | |||
protos/flyteidl/service/admin.proto
Outdated
| @@ -636,4 +636,14 @@ service AdminService { | |||
| // description: "Retrieve metrics from an existing workflow execution." | |||
| // }; | |||
| }; | |||
|
|
|||
| // Fetches FlyteKit metrics for a :ref:`ref_flyteidl.admin.NodeExecution`. | |||
| rpc GetFlyteKitMetrics (flyteidl.admin.NodeExecutionGetRequest) returns (flyteidl.admin.WorkflowExecutionGetMetricsResponse) { | |||
There was a problem hiding this comment.
Should we rename it to GetTaskMetrics? cc @hamersaw
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 75.92% 78.48% +2.55%
==========================================
Files 18 18
Lines 1458 1250 -208
==========================================
- Hits 1107 981 -126
+ Misses 294 212 -82
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jun 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is part of Flytekit Metrics Exploration
This PR(also highlighted in green):
GetFlyteKitMetrics.Flytekit Metrics Exploration includes:
flytekit: Upload Flytekit runtime metrics to S3 flytekit#1683
flyteplugins: Add GetSpanPath and SpanExists flyteplugins#361
flyteidl: Add span uri #415
flytepropeller: Add span uri to node event flytepropeller#577
flyteadmin: Implement GetFlyteKitMetrics endpoint flyteadmin#575
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/