Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Revert "GPU Type (#419)" #444

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Revert "GPU Type (#419)" #444

merged 2 commits into from
Sep 25, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Sep 22, 2023

This reverts commit ef37788.

Reverting in favor of storing extended resource information in core.Resources.

This reverts commit ef37788.

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb force-pushed the jeev/revert-resource-metadata branch from 5bbce85 to 889c352 Compare September 22, 2023 19:30
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.55% 🎉

Comparison is base (b130a81) 75.92% compared to head (b6f13dc) 78.48%.

❗ Current head b6f13dc differs from pull request most recent head 889c352. Consider uploading reports for the commit 889c352 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   75.92%   78.48%   +2.55%     
==========================================
  Files          18       18              
  Lines        1458     1250     -208     
==========================================
- Hits         1107      981     -126     
+ Misses        294      212      -82     
  Partials       57       57              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevb jeevb marked this pull request as ready for review September 25, 2023 21:19
@jeevb jeevb merged commit 572e29f into master Sep 25, 2023
13 checks passed
@jeevb jeevb deleted the jeev/revert-resource-metadata branch September 25, 2023 21:19
@welcome
Copy link

welcome bot commented Sep 25, 2023

Congrats on merging your first pull request! 🎉

eapolinario pushed a commit that referenced this pull request Sep 28, 2023
* Revert "GPU Type (#419)"

This reverts commit 7bd98a9.

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>

* Restore .readthedocs.yml

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>

---------

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants