Feat: If PKCE AuthorizationClient cannot open browser, ask user to do so manually #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg91
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
…nually Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
fg91
force-pushed
the
fg91/feat/pkce-open-browser-manually
branch
from
34cef30
to
2fb0e8e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
- Coverage 62.71% 62.70% -0.01%
==========================================
Files 313 313
Lines 23178 23181 +3
Branches 3510 3511 +1
==========================================
+ Hits 14535 14536 +1
- Misses 8221 8223 +2
Partials 422 422
☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Nov 9, 2023
fg91
commented
Nov 9, 2023
eapolinario
approved these changes
Nov 9, 2023
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
fg91
force-pushed
the
fg91/feat/pkce-open-browser-manually
branch
from
65b1129
to
4bb5640
Compare
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
… so manually (flyteorg#1947) * If PKCE AuthorizationClient cannot open browser, ask user to do so manually Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> * Remove new line Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> --------- Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
… so manually (flyteorg#1947) * If PKCE AuthorizationClient cannot open browser, ask user to do so manually Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> * Remove new line Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> --------- Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The PKCE
AuthorizationClientautomatically opens a browser tab/window with the/authorizeendpoint in order to receive the authorization code.When ssh-ing into VMs, the browser window cannot be automatically opened. If one port-forwards the port used by the callback server, a pkce flow could still be done if only the authorization endpoint could be opened in the user's browser.
In this PR I change the
AuthorizationClientso that it first tries to open the browser window automatically - as is already the case - but if this is not successful, simply asks the user to open the link.Type
Are all requirements met?
Complete description
NA
Tracking Issue
NA
Follow-up issue
NA