MAINT Remove pytz dependency #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 62.62% 62.55% -0.08%
==========================================
Files 313 313
Lines 23217 23245 +28
Branches 3519 3523 +4
==========================================
+ Hits 14540 14541 +1
- Misses 8255 8283 +28
+ Partials 422 421 -1 ☔ View full report in Codecov by Sentry. |
eapolinario
reviewed
Nov 17, 2023
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
eapolinario
approved these changes
Nov 17, 2023
pingsutw
approved these changes
Nov 19, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* MAINT Remove pytz dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * FIX Fixes typo Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* MAINT Remove pytz dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * FIX Fixes typo Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
pytzdependency.Type
Are all requirements met?
Complete description
pytzwas only used to getUTC, which can be directly replaced withtimezone.utc.Tracking Issue
Towards flyteorg/flyte#4418