Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _literal_map_to_python_input to base task #2150

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 30, 2024

Tracking issue

NA

Why are the changes needed?

Add _literal_map_to_python_input base tasks. It allows people to override it, and preprocess the input before deserializing the literal map.

What changes were proposed in this pull request?

Add _literal_map_to_python_input method the base tasks

How was this patch tested?

Unit tests

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pingsutw pingsutw marked this pull request as draft January 30, 2024 12:27
@pingsutw pingsutw self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b8ad7e) 85.79% compared to head (54c1ba6) 85.80%.
Report is 9 commits behind head on master.

❗ Current head 54c1ba6 differs from pull request most recent head b70b8ed. Consider uploading reports for the commit b70b8ed to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2150   +/-   ##
=======================================
  Coverage   85.79%   85.80%           
=======================================
  Files         313      313           
  Lines       23576    23581    +5     
  Branches     3530     3530           
=======================================
+ Hits        20228    20233    +5     
  Misses       2738     2738           
  Partials      610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pingsutw pingsutw marked this pull request as ready for review January 31, 2024 23:45
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pingsutw pingsutw merged commit f721eef into master Feb 1, 2024
80 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants