Container Image should be an input into computing the task version

[pingsutw]

Tracking issue

flyteorg/flyte#4904

Why are the changes needed?

Failed to register a workflow if users update the dependencies in the requirement.txt in the imageSpec.

What changes were proposed in this pull request?

hash should be calculated from the image spec and workflow file

How was this patch tested?

pyflyte run

Setup process

from flytekit import task, workflow
from flytekit.image_spec import ImageSpec

image_spec2 = ImageSpec(
    requirements="requirements.txt",  # python packages to install
    registry="pingsutw")


@task(container_image=image_spec2)
def say_hello(name: str) -> str:
    return f"hello {name}!"


@workflow
def sub_wf(name: str = "union"):
    say_hello(name=name)


@workflow
def wf(name: str = "union"):
    sub_wf(name=name)

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ea8687b) 80.43% compared to head (3a76711) 85.53%.
Report is 15 commits behind head on master.

Files	Patch %	Lines
flytekit/remote/remote.py	75.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2194      +/-   ##
==========================================
+ Coverage   80.43%   85.53%   +5.09%     
==========================================
  Files         176      309     +133     
  Lines       17178    23460    +6282     
  Branches     3545     3630      +85     
==========================================
+ Hits        13817    20066    +6249     
- Misses       2732     2752      +20     
- Partials      629      642      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

Can you add a few tests?

[pingsutw]

Can you add a few tests?

done