Fix local overwrite cache #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com>
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com>
ChungYujoyce
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2198 +/- ##
==========================================
- Coverage 85.53% 85.52% -0.01%
==========================================
Files 309 309
Lines 23460 23467 +7
Branches 3630 3632 +2
==========================================
+ Hits 20066 20070 +4
- Misses 2752 2753 +1
- Partials 642 644 +2 ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Feb 20, 2024
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com>
eapolinario
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Thank you.
Don't worry about the failing unit tests in https://github.com/flyteorg/flytekit/actions/runs/7969843181/attempts/2?pr=2198, those are being fixed in #2199.
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Fix local overwrite cache Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com> * take off print Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com> * change overwrite logic Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com> --------- Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#4727
Why are the changes needed?
We can't overwrite the cache when using
pyflyte run --overwrite-cachein local runs.What changes were proposed in this pull request?
--overwrite-cacheis added, we getrun_level_params.overwrite_cache=Trueand set the environment variableFLYTE_LOCAL_CACHE_OVERWRITE=trueaccordingly.FLYTE_LOCAL_CACHE_OVERWRITE=true, the task will be executed and overwrite the existing cache.addfunction inLocalTaskCacheis changed tosetas the previous one can't update the cache if there's already an existing one.How was this patch tested?
Added a test which confirms that setting
FLYTE_LOCAL_CACHE_OVERWRITE=truecan successfully overwrite the existing cache.Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link