Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes failing test related to TaskNodeOverrides #2230

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

thomasjpfan
Copy link
Member

Tracking issue

Follow up to #2176

Why are the changes needed?

What changes were proposed in this pull request?

Fixes failing test:

def test_task_node_overrides():
overrides = _workflow.TaskNodeOverrides(
Resources(
requests=[Resources.ResourceEntry(Resources.ResourceName.CPU, "1")],
limits=[Resources.ResourceEntry(Resources.ResourceName.CPU, "2")],
),
tasks_pb2.ExtendedResources(gpu_accelerator=T4.to_flyte_idl()),
)

How was this patch tested?

Failing tests should pass now.

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (eb20459) to head (c62306b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   84.74%   85.92%   +1.18%     
==========================================
  Files         315      315              
  Lines       24142    24142              
  Branches     3666     3666              
==========================================
+ Hits        20458    20745     +287     
+ Misses       3025     2744     -281     
+ Partials      659      653       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 1, 2024
@eapolinario eapolinario merged commit 784c08b into flyteorg:master Mar 1, 2024
88 of 90 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants