Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monodocs build #2235

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Fix Monodocs build #2235

merged 8 commits into from
Mar 4, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 4, 2024

Fix Monodocs build errors in CI

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (f1b5eba) to head (4a09900).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
+ Coverage   79.18%   85.98%   +6.79%     
==========================================
  Files         178      320     +142     
  Lines       17692    24243    +6551     
  Branches     3666     3666              
==========================================
+ Hits        14010    20845    +6835     
+ Misses       3055     2746     -309     
- Partials      627      652      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
katrogan
katrogan previously approved these changes Mar 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 4, 2024
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 4, 2024
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 4, 2024
@eapolinario eapolinario merged commit 4a58a67 into master Mar 4, 2024
92 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
* Fix Monodocs build

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* SETUPTOOLS_SCM_PRETEND_VERSION=2.0.0

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* nit

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* test

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* test

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* test

Signed-off-by: Kevin Su <pingsutw@gmail.com>

* test

Signed-off-by: Kevin Su <pingsutw@gmail.com>

---------

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants