Ensure that annotations are dropped in the case of the dataclass and dict type transformers #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in general Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:M
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
- Coverage 83.50% 76.02% -7.49%
==========================================
Files 324 180 -144
Lines 24754 18062 -6692
Branches 3734 3527 -207
==========================================
- Hits 20672 13731 -6941
- Misses 3452 3733 +281
+ Partials 630 598 -32 ☔ View full report in Codecov by Sentry. |
thomasjpfan
previously approved these changes
Apr 3, 2024
wild-endeavor
previously approved these changes
Apr 3, 2024
pingsutw
previously approved these changes
Apr 3, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
dismissed stale reviews from pingsutw, wild-endeavor, and thomasjpfan
via
35dc708
dosubot
bot
added
size:L
eapolinario
changed the title
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
approved these changes
Apr 3, 2024
ChungYujoyce
pushed a commit
to ChungYujoyce/flytekit
that referenced
this pull request
Apr 5, 2024
…dict type transformers (flyteorg#2318) The original exception in the `DictTransformer` was put in place to catch the case of `FlyteAnnotation` being set passed to annotated dictionary, e.g. `Annotated[dict, FlyteAnnotation("annotation-1")]` is invalid. A similar argument applies to the dataclass type transformer. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
…dict type transformers (#2318) The original exception in the `DictTransformer` was put in place to catch the case of `FlyteAnnotation` being set passed to annotated dictionary, e.g. `Annotated[dict, FlyteAnnotation("annotation-1")]` is invalid. A similar argument applies to the dataclass type transformer. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The original exception in the
DictTransformerwas put in place to catch the case ofFlyteAnnotationbeing set passed to annotated dictionary, e.g.Annotated[dict, FlyteAnnotation("annotation-1")]is invalid. A similar argument applies to the dataclass type transformer.What changes were proposed in this pull request?
Keep the original exception, but only raise it if the annotation contains a
FlyteAnnotationin both the dataclass and the dictionary transformers.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link