[wip] Use Json type to represent naked dictionaries #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
|
|
||
| def to_literal( | ||
| self, ctx: FlyteContext, python_val: typing.Any, python_type: Type[dict], expected: LiteralType | ||
| ) -> Literal: | ||
| if type(python_val) != dict: | ||
| raise TypeTransformerFailedError("Expected a dict") | ||
|
|
||
| if expected and expected.simple and expected.simple == SimpleType.STRUCT: | ||
| # TODO: back-compat with struct |
There was a problem hiding this comment.
I don't think we should do any backwards compat right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5318
Why are the changes needed?
As described in flyteorg/flyte#5318, we can use a json string as the transport for a variety of types, including naked dictionaries.
What changes were proposed in this pull request?
Leverage the new Json type defined in flyteorg/flyte#5337 to replace the usage of protobuf Struct as the transport for naked dictionaries with a json-encoded string.
Keep in mind that this is WIP. TODO:
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link