Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBT plugin test #2454

Merged
merged 24 commits into from
Jun 3, 2024
Merged

Fix DBT plugin test #2454

merged 24 commits into from
Jun 3, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented May 31, 2024

Tracking issue

flyteorg/flyte#5351

Why are the changes needed?

What changes were proposed in this pull request?

Set upper bound for dbt-core

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier marked this pull request as draft May 31, 2024 04:14
@Future-Outlier Future-Outlier changed the title Fix DBT plugin test [WIP] Fix DBT plugin test May 31, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title [WIP] Fix DBT plugin test Fix DBT plugin test Jun 1, 2024
@Future-Outlier Future-Outlier marked this pull request as ready for review June 1, 2024 02:17
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (fe0467c) to head (585f211).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2454       +/-   ##
===========================================
+ Coverage   73.51%   95.18%   +21.66%     
===========================================
  Files         234       27      -207     
  Lines       20482     1621    -18861     
  Branches     3610        0     -3610     
===========================================
- Hits        15058     1543    -13515     
+ Misses       4800       78     -4722     
+ Partials      624        0      -624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title Fix DBT plugin test [WIP] Fix DBT plugin test Jun 1, 2024
@Future-Outlier Future-Outlier marked this pull request as draft June 1, 2024 13:34
plugins/flytekit-dbt/setup.py Outdated Show resolved Hide resolved
plugins/flytekit-dbt/setup.py Outdated Show resolved Hide resolved
Future-Outlier and others added 3 commits June 2, 2024 09:42
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: pingsutw  <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as ready for review June 3, 2024 03:16
@pingsutw pingsutw changed the title [WIP] Fix DBT plugin test Fix DBT plugin test Jun 3, 2024
@pingsutw pingsutw merged commit 69a3218 into master Jun 3, 2024
48 checks passed
"flytekit>=1.3.0b2,<2.0.0",
"dbt-core>=1.0.0",
"flytekit>=1.3.0b2",
"dbt-core<1.8.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are setting this?

@eapolinario eapolinario mentioned this pull request Jun 4, 2024
3 tasks
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: pingsutw <pingsutw@apache.org>
Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants