Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_image_spec #2477

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Fix test_image_spec #2477

merged 11 commits into from
Jun 12, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jun 12, 2024

Tracking issue

https://github.com/flyteorg/flytekit/actions/runs/9475012693/job/26105636011

Why are the changes needed?

Unit test is failing

What changes were proposed in this pull request?

if image registry is localhost:30000, we should not use request to check if the image exists on docker hub

How was this patch tested?

unit test

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw changed the title test Fix test_image_spec Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.54%. Comparing base (7ddfb9b) to head (a959720).
Report is 1 commits behind head on master.

Files Patch % Lines
flytekit/image_spec/image_spec.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2477       +/-   ##
===========================================
- Coverage   80.12%   44.54%   -35.59%     
===========================================
  Files         185      204       +19     
  Lines       18636    19584      +948     
  Branches     3853     3640      -213     
===========================================
- Hits        14933     8724     -6209     
- Misses       3056    10752     +7696     
+ Partials      647      108      -539     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit 63f190e into master Jun 12, 2024
46 of 48 checks passed
bgedik pushed a commit to bgedik/flytekit that referenced this pull request Jul 3, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: bugra.gedik <bugra.gedik@predera.ai>
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants