-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_image_spec #2477
Merged
Merged
Fix test_image_spec #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy and
samhita-alla
as code owners
June 12, 2024 19:02
pingsutw
commented
Jun 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2477 +/- ##
===========================================
- Coverage 80.12% 44.54% -35.59%
===========================================
Files 185 204 +19
Lines 18636 19584 +948
Branches 3853 3640 -213
===========================================
- Hits 14933 8724 -6209
- Misses 3056 10752 +7696
+ Partials 647 108 -539 ☔ View full report in Codecov by Sentry. |
3 tasks
wild-endeavor
approved these changes
Jun 12, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: bugra.gedik <bugra.gedik@predera.ai>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Jan Fiedler <jan@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flytekit/actions/runs/9475012693/job/26105636011
Why are the changes needed?
Unit test is failing
What changes were proposed in this pull request?
if image registry is
localhost:30000
, we should not userequest
to check if the image exists on docker hubHow was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA