This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Flyte node timeout is an usererror #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 50.01% 51.08% +1.07%
==========================================
Files 128 129 +1
Lines 7966 8218 +252
==========================================
+ Hits 3984 4198 +214
- Misses 3594 3616 +22
- Partials 388 404 +16
Continue to review full report at Codecov.
|
|
How did this improve coverage? |
EngHabu
approved these changes
Apr 16, 2020
|
Unit test? |
|
@kumare3 probably because this line was already being covered in a test, and since we increased the size of the block, it looked like more code (percentage) is covered |
|
How did this improve coverage?
|
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
* introduce pr to update project repo * wip * wip * wip + merge * wip + compiles woot woot * don't return types where unused; db write * check for writeTx error * interface * use get * add first integration test * cmts * fix * new integration test * ci * apologies for all the commits; running CI off GitHub * nit * api update * update mock interface * wip * mock update * lol * bump back some dependencies * dep * unit test and migration * protobuf * should be last dep change * revert go.mode and make compile * mock out more things, fix white space * wip * wip * gofmt * project * Update pkg/repositories/gormimpl/project_repo.go Co-authored-by: Katrina Rogan <krogan@lyft.com> * Update pkg/repositories/gormimpl/project_repo.go Co-authored-by: Katrina Rogan <krogan@lyft.com> * cmnts * truncate tables before tests * update integration test * integration test * := Co-authored-by: Konstantin Gizdarski <kgizdarski@lyft.com> Co-authored-by: Katrina Rogan <krogan@lyft.com>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Flyte node timeout is an usererror * Update executor.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Node timeout error should be tagged as an user error
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#277