This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Remove resource injection on the node for container task #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm probably missing something but should we be trying to do that here? https://github.com/flyteorg/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/container_helper.go#L305 What issue are you seeing, @ByronHsu ? |
|
@EngHabu Thanks for the quick reply. Yes, I have another PR injecting the resource there. See the attachment in the PR flyteorg/flyte#3540. |
ByronHsu
force-pushed
the
gh/container-resource
branch
from
e57edbf
to
e377136
Compare
Signed-off-by: byhsu <byhsu@linkedin.com>
Signed-off-by: byhsu <byhsu@linkedin.com>
ByronHsu
force-pushed
the
gh/container-resource
branch
from
2fa2518
to
9efb52f
Compare
hamersaw
reviewed
Apr 10, 2023
Signed-off-by: byhsu <byhsu@linkedin.com>
hamersaw
approved these changes
Apr 11, 2023
2 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Remove resource injection on the node for container task Signed-off-by: byhsu <byhsu@linkedin.com> * fix conflict Signed-off-by: byhsu <byhsu@linkedin.com> * fix lint Signed-off-by: byhsu <byhsu@linkedin.com> * downgrade plugin Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
Closed
2 tasks
8 tasks
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove resource injection on the node for container task
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
In BuildRawContainer, we do not inject the container resource from the task template. Instead, we inject the resource from parameters.TaskExecMetadata.GetOverrides().GetResources().
This is because for both
_with_override(resource=...and@task(requests=...), they are both inject as the node resource override in buildNodeSpecExpected behavior
For the case of
@task(requests=...), the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainerTracking Issue
flyteorg/flyte#3540