-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Is this just watching kube events? If so, we should increased the throughput on kubeclient. Do not write kube events. That impacts kubeapi drastically |
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
…into k8s-events Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Codecov Report
Additional details and impacted files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but will defer to Dan here for approval :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once idl and plugins are merged.
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
…into k8s-events Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Correct, this just watches k8s events. It uses a separate clientset vs the KubeClient in flyteplugins in order to create a filtered informer. |
TL;DR
Add support for watching and sending batched kubernetes object events in
TaskExecutionEvent
Type
Are all requirements met?
Complete description
This change adds support for watching and sending batched kubernetes object events in
TaskExecutionEvent
. ItTaskExecutionEvent.reasons
fieldK8sPluginConfig.SendObjectEvents
)Testing
Ran single binary locally and got the following console output
Looking at the execution closure
Tracking Issue
flyteorg/flyte#3825
Follow-up issue
N/A