This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Read PodTemplates by default. #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com>
chaohengstudent
requested review from
kumare3,
EngHabu and
hamersaw
as code owners
Codecov Report
Additional details and impacted files |
hamersaw
approved these changes
Sep 11, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR let PodTemplates read by default.
Type
Are all requirements met?
Complete description
Remove the condition check for setting the default podTemplates name when starting the informerFactory.
Tracking Issue
fixes flyteorg/flyte#3946
Follow-up issue
NA