refactor(pathlib): Replace os.path with pathlib #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
force-pushed
the
feature/pathlib-replace-ospath
branch
3 times, most recently
from
4a11f41
to
7ce27e8
Compare
pingsutw
previously approved these changes
Apr 30, 2024
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/pathlib-replace-ospath
branch
from
6ad2edc
to
2d920af
Compare
MortalHappiness
force-pushed
the
feature/pathlib-replace-ospath
branch
from
4b47d99
to
2146424
Compare
…/pathlib-replace-ospath
MortalHappiness
force-pushed
the
feature/pathlib-replace-ospath
branch
from
2146424
to
ad68489
Compare
…/pathlib-replace-ospath
pingsutw
approved these changes
May 24, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
os.pathwithpathlibto improve readability.Related PR: flyteorg/flyte#5243