Skip to content

Conversation

0wu
Copy link

@0wu 0wu commented Sep 23, 2015

(1) so the BatchProviderROI inherited fields can be properly saved by torch.save
(2) The following code produce correct output

require('nnf')
bp1 = nnf.BatchProviderROI({dataset="1"})
print(bp1.dataset) --prints 1
bp2 = nnf.BatchProviderROI({dataset="2"})
print(bp1.dataset) --prints 2 (should be 1)

so the  BatchProviderROI inherited fields can be properly saved by torch.save
fmassa added a commit that referenced this pull request Sep 23, 2015
Fix BatchProviderROI incorrect super constructor invokation
@fmassa fmassa merged commit 9c3e73f into fmassa:fast-rcnn Sep 23, 2015
@fmassa
Copy link
Owner

fmassa commented Sep 23, 2015

Thanks!
I'm refactoring all the code so that it's more modular/extensible, it's in branch refactoring. I'll add your changes there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants