Event listener memory safety and usability upgrades #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issues with the AttachInstanceToGameObject methods. This mainly fixes issues when being called via the PlayOneShotAttached method. AttachInstanceToGameObject now directly sets the 3dAttribute while attaching to ensure an initial correct and valid 3d positioning is applied. Before a 3d position would only by applied to the instance in the next update after the attach occured. This can cause unexpected and unwanted results in case the target transform was destroyed between the attach and the update loop. Example: A crate that plays a PlayOneShotAttached when it hits a surface but that also takes damage at the same time that can result in a destroy. The sound would play at the incorrect location as there was never an initial position set that matched the desired start position. This small change will fix this.
Updated the DrawDebugOverlay to no longer cause Garbage allocation as long as the overlay isn't enabled. Before: OnGUI would always be called resulting in the Unity OnGUI to be active no matter what, generating unwanted overhead and garbage. Now: As long as the debugoverlay isn't active no garbage will be allocated. A safety is also added to avoid the overhead being applied in a non editor build by accident. Can be adjusted if desired.
Added a some safety code to ensure emitters are nicely cleaned up on destroy. Added the ability to SetParameter by index instead of string
This reverts commit 4a25a69.
This reverts commit 915a6e9.
brechtos
changed the title
Reduces newstring GC
|
Thanks for the contribution, this has been added for release 1.10.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a some safety code to ensure emitters are nicely cleaned up on destroy.
Added the ability to SetParameter by index instead of string