Fix deletion of configs #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new V2 API, to delete a config entry, you need to set the value to an empty string. If you don't do this, the system doesn't realise you've made any changes and therefore doesn't update the config. Update the code to support this functionality. Contributes to fnproject#52.
The Fn/App config was duplicated on both the App and Fn form. By moving it to its own component it means we only have to maintain it in one place. For example, I recently fixed the deletion of config lines. Having one component to edit means I only need to apply the fixes to one place. As a consequence of this, it also means it fixes the deletion of config points for Apps - prior to this change deleting the config row wouldn't have any effect and you'd need to set the config value to an empty string to delete it.
carimura
approved these changes
Apr 25, 2019
|
sweet |
|
i moved too quickly. just tested and doesn't seem to be deleting config vars from UI... |
|
related: #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR if you used the
Xbutton to delete a config for an app or function (as the interface intends) then it wouldn't make any changes. This is because the config data isn't included in thePUTrequest so the API doesn't think it's been changed. The correct way of deleting a config with the new V2 API is to set its value to an empty string. I have changed the code so it does this behind the scenes, whilst keeping the frontend appearance the same.I have also separated the config logic into its own Vue component and shared it between apps and functions to remove the duplicated code.
To test:
fn inspectthat the config has been updated accordinglyI have also tested deleting a config and then adding it back prior to clicking submit and this works correctly.
This PR contributes to #52