Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR if you used the
X
button to delete a config for an app or function (as the interface intends) then it wouldn't make any changes. This is because the config data isn't included in thePUT
request so the API doesn't think it's been changed. The correct way of deleting a config with the new V2 API is to set its value to an empty string. I have changed the code so it does this behind the scenes, whilst keeping the frontend appearance the same.I have also separated the config logic into its own Vue component and shared it between apps and functions to remove the duplicated code.
To test:
fn inspect
that the config has been updated accordinglyI have also tested deleting a config and then adding it back prior to clicking submit and this works correctly.
This PR contributes to #52