Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD build #51

Merged
merged 3 commits into from
Aug 22, 2020
Merged

Add UMD build #51

merged 3 commits into from
Aug 22, 2020

Conversation

bbenjamin
Copy link
Contributor

I'm evaluating replacements for jQuery UI's :tabbable in Drupal core, since jQueryUI is end-of-life. I have a strong preference for tabbable, but to be used in Drupal it would needs to be available as a global variable definition. The UMD files generated by this patch work great in Drupal, so I'm hoping you're open to adding this as an option.

Also happy to assist on other issues that the next release is waiting on.

@davidtheclark
Copy link
Collaborator

@bbenjamin I'm not actively developing this project, so it would be great if you'd like to take over maintenance (I can add you as a collaborator) or fork it!

Copy link
Member

@stefcameron stefcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this target.

@stefcameron stefcameron merged commit 81ccf36 into focus-trap:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants