Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COLRv1 Support #270

Closed
jlarmstrongiv opened this issue Jan 18, 2022 · 10 comments
Closed

COLRv1 Support #270

jlarmstrongiv opened this issue Jan 18, 2022 · 10 comments

Comments

@jlarmstrongiv
Copy link

jlarmstrongiv commented Jan 18, 2022

@Pomax
Copy link
Contributor

Pomax commented Jan 18, 2022

Note that the real spec is https://docs.microsoft.com/en-us/typography/opentype/spec/colr#colr-formats, though. The github repo is just the working location, inclusion in the OpenType spec is when things become official.

@jlarmstrongiv
Copy link
Author

Great find @Pomax!

I haven’t worked much with parsers, but I think your svg example and restructure is interesting.

I can extract and post my existing COLRv0 code and then explore how to add support for the new features.

@Pomax
Copy link
Contributor

Pomax commented Jan 24, 2022

In terms of the parser: we can probably hack something into existence, similar to what we did with the SVG parser, as COLRv1 isn't terribly complex, just "a lot more (linked) simple structures". The tricky bit will be in turning them into something you can actually see.

@jlarmstrongiv
Copy link
Author

@Pomax it certainly sounds possible. If you’re able to hack together the parser, then I will be able to format and massage the data into a usable svg. I think it’d be useful to other people in the future too 😄

@Pomax
Copy link
Contributor

Pomax commented Jan 30, 2022

stubbing something out over on https://github.com/Pomax/fontkit-colrv1, but it's a lot of small bits of code, so no promises on when I might finish (if ever, because "yet another repo" is exactly what my overloaded schedule needed ;)

Unless someone wants to commission this work, of course, then things become radically different =D

@jlarmstrongiv
Copy link
Author

Thank you @Pomax ! That’s a great start. What’s the best way to contact you?

@Pomax
Copy link
Contributor

Pomax commented Feb 3, 2022

Email's best, although I may be slow to respond (I think you already emailed me) because things have gotten a bit crazy and I'm currently balancing "having to use a keyboard" with "not actually being able to use a keyboard due to an injury" >_>

@jlarmstrongiv
Copy link
Author

Ouch! Hope you make a full recovery @Pomax. I remember a few tips for hands-free coding from https://www.joshwcomeau.com/blog/hands-free-coding/ Feel free to followup in a few weeks or a few months, whenever you feel better with schedule permitting.

@Lorp
Copy link

Lorp commented Jul 17, 2023

This is @simoncozens’ PR for COLRv1 support: #298

@jlarmstrongiv
Copy link
Author

Closing in favor of #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants