Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Attached buttons were shown above dropdown menu list #333

Merged
merged 1 commit into from
Jan 3, 2019
Merged

[Button] Attached buttons were shown above dropdown menu list #333

merged 1 commit into from
Jan 3, 2019

Conversation

lubber-de
Copy link
Member

Description

The static z-index of attached buttons prevented dropdown Menu list to be shown above, when a dropdown was created in another attached buttons container.

Testcase

  • Open the top dropdown, works fine
  • Remove the CSS part, re-run the fiddle and open the upper dropdown button again to see the issue
    https://jsfiddle.net/w2jayvsf/

Screenshot

semantic

Closes

Semantic-Org/Semantic-UI#5355

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Dec 31, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 31, 2018
y0hami
y0hami approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ColinFrick
Copy link
Member

The z-Index was introduced in this commit: Semantic-Org/Semantic-UI@406a95c for issue Semantic-Org/Semantic-UI#2334, would this change work with that?
There seems some connection with animated buttons (z-index: 1) and the (or)-button element (z-index: 3)

@lubber-de
Copy link
Member Author

lubber-de commented Dec 31, 2018 •
edited
Loading

@ColinFrick Yes, I was looking for every z-index setting before. That's why i put those extra buttons animated button and orbuttons into the fiddle 😉 to test their z-index is still working. The mentioned issue requested to support attached buttons which is also covered in the jsfiddle.
If the change would not work then the extra buttons would not appear in the button group...but they do 🙂 , so from my POV this is covered and working

ColinFrick
ColinFrick approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 3, 2019
@y0hami y0hami merged commit 08e6406 into fomantic:develop Jan 3, 2019
@lubber-de lubber-de deleted the fix/5355/attached_buttons_z-index branch January 3, 2019 09:11
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 3, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
@iarspider iarspider mentioned this pull request Mar 8, 2019
Merged
@smartm0use smartm0use mentioned this pull request May 7, 2019
Closed
@awakenalive awakenalive mentioned this pull request May 12, 2019
Closed
@smartm0use smartm0use mentioned this pull request May 20, 2019
Closed
@bborn bborn mentioned this pull request Jun 7, 2019
Closed
@ahuho ahuho mentioned this pull request Sep 30, 2019
Closed
This was referenced Oct 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami