Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List,Icon] List Item Icon Rotates Around Wrong Point when using Loading class #336

Merged
merged 1 commit into from
Dec 31, 2018
Merged

[List,Icon] List Item Icon Rotates Around Wrong Point when using Loading class #336

merged 1 commit into from
Dec 31, 2018

Conversation

lubber-de
Copy link
Member

Description

When adding the loading class to an icon in a list item, the entire icon rotates around a wrong point rather than rotating about it's own center.

Testcase

http://jsfiddle.net/pn75L2tj/

  • first list item shows the issue
  • second item is fixed
  • third one is normal item without loading class (to show alignment)

Closes

Semantic-Org/Semantic-UI#6717

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Dec 31, 2018
@lubber-de lubber-de added this to the 2.7.x milestone Dec 31, 2018
ColinFrick
ColinFrick approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 80df182 into fomantic:develop Dec 31, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Dec 31, 2018
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Dec 31, 2018
@lubber-de lubber-de deleted the fix/6717/list_icon_loading_position branch December 31, 2018 18:41
@lubber-de lubber-de mentioned this pull request Jan 4, 2019
Merged
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami