Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Make "link" and "disabled" work together correctly #344

Merged
merged 1 commit into from
Jan 2, 2019
Merged

[Icon] Make "link" and "disabled" work together correctly #344

merged 1 commit into from
Jan 2, 2019

Conversation

lubber-de
Copy link
Member

Description

  • disabled and link icon(s) at the same time ignored the disabled setting
  • icons (grouped) did also not work everywhere with those settings
  • some CSS pseudoclass settings were wrong (for example .hover instead iof :hover)
  • unnecessary !important values removed (which also partially caused the issue)

Testcase

Before

https://jsfiddle.net/vnmgt6y9/3/
from original SUI Issue

After

https://jsfiddle.net/akym370t/
Because of the !important removements in the PR i prepared a similiar testcase having the same CSS settings given

Closes

Semantic-Org/Semantic-UI#5694

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 1, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 1, 2019
y0hami
y0hami approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit cef454e into fomantic:develop Jan 2, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 2, 2019
@lubber-de lubber-de deleted the fix/5694/icon_disabled_link branch January 2, 2019 08:40
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 2, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami