Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] checkbox and radio (with errors) were only reset if the first option was selected #349

Merged

Conversation

lubber-de
Copy link
Member

Description

After validation fails, checkboxes and radios with multiple options were only reset if the first option was selected.

Testcase

Unfixed

https://jsfiddle.net/kmd1970/6d3dp1xq/

Fixed

https://jsfiddle.net/u2abzw3r/

Closes

Semantic-Org/Semantic-UI#5072

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 2, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 2, 2019
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 6e41efe into fomantic:develop Jan 3, 2019
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 3, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 4, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
@lubber-de lubber-de deleted the fix/5072/validation_checkbox_radio branch February 5, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants