Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Missing pseudo-class leads to invisible list item #354

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Jan 2, 2019

Description

This is obviously an old typo or copy/paste mistake and seems to affect only a few users at all.
In a CSS group of conditions which are obviously made for the :after pseudo-element, one line has the pseudo-class missing.
But this isn't just a typo, it actually leads into an invisible list item in case your code had exactly the matching DOM structure .ui.list > .list > .item, which i prepared in the jsfiddle below

Testcase

http://jsfiddle.net/mgk0rbd6/

Closes

Semantic-Org/Semantic-UI#4526

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 2, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 2, 2019
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit e1d2098 into fomantic:develop Jan 3, 2019
@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jan 3, 2019
@lubber-de lubber-de deleted the fix/4536/missing_pseudo_class branch January 3, 2019 09:03
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 3, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants