-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment, Menu] "secondary segment" or "secondary menu" have a different meaning #366
Merged
y0hami
merged 2 commits into
fomantic:develop
from
lubber-de:fix/364/secondary_overrides
Jan 7, 2019
Merged
[Segment, Menu] "secondary segment" or "secondary menu" have a different meaning #366
y0hami
merged 2 commits into
fomantic:develop
from
lubber-de:fix/364/secondary_overrides
Jan 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent meaning, thus remove it from dynamic color creation
y0hami
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ColinFrick
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 10, 2019
Merged
y0hami
pushed a commit
that referenced
this pull request
Apr 16, 2019
…er needed The additional specificity for `secondary inverted menu` was necessary (when 2.7.0 was released) to override a background color setting when `secondary` was still supported as a background color for menus. We removed this in #366 , so the additional specificity is not needed anymore Closes #672
exoego
pushed a commit
to exoego/Fomantic-UI
that referenced
this pull request
Apr 30, 2019
…er needed The additional specificity for `secondary inverted menu` was necessary (when 2.7.0 was released) to override a background color setting when `secondary` was still supported as a background color for menus. We removed this in fomantic#366 , so the additional specificity is not needed anymore Closes fomantic#672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
secondary
is part of the new central dynamic color map from #316.Unfortunately there already was
secondary segment
andsecondary menu
available, but not meant as color variant resulting in different visual behavior as before.To stay backward compatible, i simply removed
secondary
from the color creation loop insegment
aswell asmenu
. For all other colorizable elementssecondary
is still available (as it is a new feature since 2.7.0)I also removed
primary
for color creation insegment
because it was also separately supported previously (even if not documented)I kept
primary
for color creation inmenu
because it had no separate support before.Tell me, if i should remove this for menu aswell
Closes
#364
Version
2.7.1