[Segment, Menu] "secondary segment" or "secondary menu" have a different meaning #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent meaning, thus remove it from dynamic color creation
lubber-de
added
lang/css
lubber-de
removed
the
state/awaiting-reviews
This was referenced Jan 10, 2019
Merged
y0hami
pushed a commit
that referenced
this pull request
Apr 16, 2019
…er needed The additional specificity for `secondary inverted menu` was necessary (when 2.7.0 was released) to override a background color setting when `secondary` was still supported as a background color for menus. We removed this in #366 , so the additional specificity is not needed anymore Closes #672
exoego
pushed a commit
to exoego/Fomantic-UI
that referenced
this pull request
Apr 30, 2019
…er needed The additional specificity for `secondary inverted menu` was necessary (when 2.7.0 was released) to override a background color setting when `secondary` was still supported as a background color for menus. We removed this in fomantic#366 , so the additional specificity is not needed anymore Closes fomantic#672
exoego
added
type/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
secondaryis part of the new central dynamic color map from #316.Unfortunately there already was
secondary segmentandsecondary menuavailable, but not meant as color variant resulting in different visual behavior as before.To stay backward compatible, i simply removed
secondaryfrom the color creation loop insegmentaswell asmenu. For all other colorizable elementssecondaryis still available (as it is a new feature since 2.7.0)I also removed
primaryfor color creation insegmentbecause it was also separately supported previously (even if not documented)I kept
primaryfor color creation inmenubecause it had no separate support before.Tell me, if i should remove this for menu aswell
Closes
#364
Version
2.7.1