[Label] Link icon cursors in corner labels did not work #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
This was referenced Jan 8, 2019
lubber-de
removed
the
state/awaiting-reviews
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
linkicons which are contained within acorner labeldo not have the desired effect of settingcursor:pointer.This is a regression since 2015 by Semantic-Org/Semantic-UI@9588488
The original intention to set
cursor:defaultwas to prevent mouse selection (according to the commit message). However i was not able to reproduce this behavior 🤔 , maybe it was a special browser fix.To be save with this intention and still support the
pointerif the label was created using anatag, i changed the value toinheritinstead.Testcase
https://fomantic-ui.com/elements/label.html#corner
Screenshot
Unfixed
Fixed
Closes
Semantic-Org/Semantic-UI#4238
Semantic-Org/Semantic-UI#5299
Semantic-Org/Semantic-UI#3809